setopt: add page #19641
setopt: add page #19641
Conversation
github-actions
bot
added
new command
msaf9
left a comment
msaf9
left a comment
There was a problem hiding this comment.
Please resolve the build failure so that we can begin the actual review process.
| @@ -0,0 +1,20 @@ | |||
| # setopt | |||
|
|
|||
| > Set/unset Z shell (zsh) options. | |||
There was a problem hiding this comment.
| > Set/unset Z shell (zsh) options. | |
| > Set/unset Z shell (Zsh) options. |
There was a problem hiding this comment.
I prefer the uncapitalized version as 'zsh' is how you invoke 'Z Shell' from the command line. 'Zsh' implies that this is the formal name of 'Z Shell'. As far as I am aware it is not.
There was a problem hiding this comment.
This isn't important though. What's important is that this confusion is clarified simply to a beginner looking for a quick understanding of how to set options in Z Shell.
It is not clear from Z Shell's official documentation the right way how to do this or how to check which options are set/unset from the command line. Not to mention a beginner looking for this documentation might not know that the tool is even called 'Z Shell' or that 'setopt' has anything to do with 'zsh'/'Z Shell' to begin with.
There was a problem hiding this comment.
I prefer the uncapitalized version as 'zsh' is how you invoke 'Z Shell' from the command line. 'Zsh' implies that this is the formal name of 'Z Shell'. As far as I am aware it is not.
It appears I'm wrong about this. I could go either way, but I think the rule about capitalizing shells should be reversed if the shell isn't capitalized in it's documentation.
|
Hello @gsspdev, could you please fix the build failure and address one of the comments from the review? |
Co-authored-by: Sahil Afrid Farookhi <[email protected]>
Co-authored-by: Sahil Afrid Farookhi <[email protected]>
Co-authored-by: Sahil Afrid Farookhi <[email protected]>
Co-authored-by: Lena Pastwa <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
4 participants
Checklist
common,linux,osx,windows,sunos,android, etc.